Update Unreal SDK to websocket 2.0#4497
Conversation
|
@jdetter I'll work with you on this for the version bump and make sure that is done and reset up once this is ready to merge. The changes have not been done yet so this comment will need to be resolved before merging. |
|
Overall this LGTM. All the key pieces are there. |
So |
rekhoff
left a comment
There was a problem hiding this comment.
My concerns have been addressed. I have not tested the PR, but this looks good to me.
Description of Changes
API and ABI breaking changes
metadata is invalid instead of continuing past setup issues.
Expected complexity level and risk
3 - A large set of changes to update the websocket/message handling along with heavy codegen changes to handle multi-module support
Testing
Test coverage of the Unreal SDK will need expansion in a future ticket once our issues with flakiness on CI is resolved.
--module-prefixReview Question(s)
spacetime inithave made the tutorial a little confusing with pathing for the Unreal Blackholio tutorial. To fix though we'd have to update all the commands to be more explicit, or update the tutorialspacetime initto use--project-path .to keep pathing simpler, thoughts?